Some nits to the smoke test. #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhalvorsen
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi and
jhand2
as code owners
zhalvorsen
force-pushed
the
zhalvorsen-nits
branch
from
a12c34b to
f40eed1
Compare
jhand2
reviewed
Jul 3, 2024
* Adds `extern C` to the header files in case of C++. * Removes an unused variable.
zhalvorsen
force-pushed
the
zhalvorsen-nits
branch
from
f40eed1 to
f058cc2
Compare
jhand2
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extern Cto the header files in case of C++