Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ECC error checking during waits #1610

Merged

Conversation

nquarton
Copy link
Contributor

No description provided.

@nquarton
Copy link
Contributor Author

I should add a test case here where we cause this error via the ECC verify service

@jlmahowa-amd jlmahowa-amd mentioned this pull request Jul 11, 2024
7 tasks
@nquarton nquarton force-pushed the ecc_driver_error_checking branch from c302612 to 94d4599 Compare July 11, 2024 19:19
@nquarton nquarton linked an issue Jul 11, 2024 that may be closed by this pull request
@nquarton nquarton force-pushed the ecc_driver_error_checking branch from 94d4599 to 0db08d6 Compare July 11, 2024 19:26
@nquarton nquarton marked this pull request as ready for review July 11, 2024 19:47
@nquarton nquarton force-pushed the ecc_driver_error_checking branch from 0db08d6 to 860abab Compare July 15, 2024 15:48
@nquarton nquarton force-pushed the ecc_driver_error_checking branch from 860abab to 5c1c73f Compare July 16, 2024 03:59
@JohnTraverAmd JohnTraverAmd merged commit 6bfd809 into chipsalliance:main Jul 16, 2024
10 checks passed
@nquarton nquarton added the ROM Issue affects ROM label Aug 2, 2024
nquarton added a commit to nquarton/caliptra-sw that referenced this pull request Aug 7, 2024
JohnTraverAmd pushed a commit that referenced this pull request Aug 15, 2024
* Changing SHA384ACC KAT to SHA512 (#1562)

* Changing SHA384ACC KAT to SHA512

- Adding support for SHA512 digest in the SHA acclerator driver
- Enabling support for SHA512 in the SW emulator SHA accelerator

* Renaming sha384acc to sha2_512_384acc

* Adding ECC error checking during waits (#1610)

* [bugfix] hmac384 driver: Reload kv keys for each block.

This fixes #1520 / #1550: HMAC operations larger than a
single block produce the incorrect results when using data or keys from
the keyvault.

Add a multi-block hmac384 test that uses the key-vault.

smoke-test: Verify FMC key derivation with independent impl.

* Updating DPE to fix sporadic test failure

* Updating ROM version to 1.0.3

* Removing publish website step for nightly release

---------

Co-authored-by: Kor Nielsen <[email protected]>
nquarton added a commit to nquarton/caliptra-sw that referenced this pull request Aug 15, 2024
jhand2 pushed a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECC Driver does not check error regs
4 participants