New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self Signed FMC Alias Csr #1863

Merged

JohnTraverAmd merged 8 commits into chipsalliance:main from rusty1968:fmc-csr-feature

Jan 30, 2025

Contributor

rusty1968 commented Dec 19, 2024

FMC modfied to generate a self signed FMC Alias CSR test upon cold boot.
Persistent driver modified to add persistent memory for the FMC Alias CSR
Runtime modified to expose an API to retrieve it.
Test case created to verify the self signed FMC Alias CSR.
Test case created to verify the RT Alias Certificate with the pub key of the FMC Alias CSR.

rusty1968 self-assigned this

rusty1968 added the Caliptra v1.2 label

rusty1968 marked this pull request as ready for review

December 19, 2024 18:14

rusty1968 requested review from jhand2, fdamato, bluegate010, mhatrevi, swenson, vsonims, FerralCoder, ajisaxena, jlmahowa-amd, korran and JohnTraverAmd as code owners

December 19, 2024 18:14

clundin25 reviewed

View reviewed changes

api/src/mailbox.rs Outdated Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

drivers/src/persistent.rs Outdated Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

error/src/lib.rs Outdated Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

fmc/src/flow/crypto.rs Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

fmc/src/flow/fmc_alias_csr.rs Outdated Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

runtime/src/get_fmc_alias_csr.rs Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

runtime/src/get_fmc_alias_csr.rs Outdated Show resolved Hide resolved

clundin25 reviewed

View reviewed changes

runtime/src/get_fmc_alias_csr.rs Outdated Show resolved Hide resolved

jhand2 reviewed

View reviewed changes

common/src/lib.rs Show resolved Hide resolved

jhand2 reviewed

View reviewed changes

drivers/src/memory_layout.rs Outdated Show resolved Hide resolved

jhand2 reviewed

View reviewed changes

drivers/src/persistent.rs Show resolved Hide resolved

jhand2 reviewed

View reviewed changes

runtime/src/main.rs Outdated Show resolved Hide resolved

rusty1968 force-pushed the fmc-csr-feature branch 4 times, most recently from ea58405 to d021950 Compare

January 2, 2025 02:48

nquarton reviewed

View reviewed changes

drivers/src/persistent.rs Outdated Show resolved Hide resolved

runtime/src/get_fmc_alias_csr.rs Show resolved Hide resolved

runtime/tests/runtime_integration_tests/test_data/fmc_alias_csr.txt Outdated Show resolved Hide resolved

runtime/tests/runtime_integration_tests/test_get_fmc_alias_csr.rs Outdated Show resolved Hide resolved

rusty1968 force-pushed the fmc-csr-feature branch 3 times, most recently from 7743a48 to 8ac3f45 Compare

January 22, 2025 15:39

nquarton previously approved these changes

View reviewed changes

rusty1968 dismissed nquarton’s stale review via

0ba785d

January 28, 2025 18:56

rusty1968 force-pushed the fmc-csr-feature branch 3 times, most recently from 388646b to c55993c Compare

January 29, 2025 16:18

clundin25 reviewed

View reviewed changes

runtime/src/get_fmc_alias_csr.rs Outdated Show resolved Hide resolved

clundin25 previously approved these changes

View reviewed changes

clundin25 reviewed

View reviewed changes

runtime/src/get_fmc_alias_csr.rs Show resolved Hide resolved

rusty1968 dismissed clundin25’s stale review via

18e4b5f

January 29, 2025 18:08

mhatrevi approved these changes

View reviewed changes

JohnTraverAmd enabled auto-merge (squash)

January 30, 2025 16:35

rusty1968 added 8 commits

January 30, 2025 08:39


          Self Signed FMC Alias Csr

6ab792b

- FMC modfied to generate a  self signed FMC Alias CSR test upon cold boot.
- Persistent driver modified to add persistent memory for the FMC Alias CSR
- Runtime modified to expose an API to retrieve it.
- Test case created to verify the self signed FMC Alias CSR.
- Test case created to verify the RT Alias Certificate with the pub key of the FMC Alias CSR.


          Code review feedback.

1004b36


          Remove fmc-alias-csr feature.

52fde4f


          NIT changes.

3e0057f


          Remove unused test_data

ecd3ff6


          Revert changes to strings.

8a57796


          Fix RESERVED_MEMORY size.

a50ac0a


          Remove dead code

e663c21

rusty1968 force-pushed the fmc-csr-feature branch from 18e4b5f to e663c21 Compare

January 30, 2025 16:39

JohnTraverAmd merged commit fa6b1a9 into chipsalliance:main

11 checks passed

nquarton linked an issue

that may be closed by this pull request

Add support for self-signed FMC_Alias CSR #1837

Closed

nquarton mentioned this pull request

Add support for self-signed FMC_Alias CSR #1837

Closed

mhatrevi pushed a commit that referenced this pull request


          Self Signed FMC Alias Csr (#1863)

d6d1cdf

* Self Signed FMC Alias Csr

- FMC modfied to generate a  self signed FMC Alias CSR test upon cold boot.
- Persistent driver modified to add persistent memory for the FMC Alias CSR
- Runtime modified to expose an API to retrieve it.
- Test case created to verify the self signed FMC Alias CSR.
- Test case created to verify the RT Alias Certificate with the pub key of the FMC Alias CSR.

* Code review feedback.

* Remove fmc-alias-csr feature.

* NIT changes.

* Remove unused test_data

* Revert changes to strings.

* Fix RESERVED_MEMORY size.

* Remove dead code

(cherry picked from commit fa6b1a9)

swenson mentioned this pull request

Linker generates unmapped segment if FMC is (3 % 4) KB in size #1971

Open

mhatrevi pushed a commit that referenced this pull request


          Self Signed FMC Alias Csr (#1863)

1acb2a8

* Self Signed FMC Alias Csr

- FMC modfied to generate a  self signed FMC Alias CSR test upon cold boot.
- Persistent driver modified to add persistent memory for the FMC Alias CSR
- Runtime modified to expose an API to retrieve it.
- Test case created to verify the self signed FMC Alias CSR.
- Test case created to verify the RT Alias Certificate with the pub key of the FMC Alias CSR.

* Code review feedback.

* Remove fmc-alias-csr feature.

* NIT changes.

* Remove unused test_data

* Revert changes to strings.

* Fix RESERVED_MEMORY size.

* Remove dead code

(cherry picked from commit fa6b1a9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jhand2 jhand2 left review comments

clundin25 clundin25 left review comments

mhatrevi mhatrevi approved these changes

nquarton nquarton left review comments

fdamato Awaiting requested review from fdamato fdamato is a code owner

bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

swenson Awaiting requested review from swenson swenson is a code owner

vsonims Awaiting requested review from vsonims vsonims is a code owner

FerralCoder Awaiting requested review from FerralCoder FerralCoder is a code owner

ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

korran Awaiting requested review from korran korran is a code owner

JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Labels