Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release artifacts for main-2.x #1945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ArthurHeymans
Copy link
Contributor

@ArthurHeymans ArthurHeymans commented Feb 5, 2025

Create releases for the main-2.x branch. Currently only sw-emulator artifacts get generated.

@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Feb 8, 2025
@ArthurHeymans ArthurHeymans force-pushed the ReleaseArtefacts branch 10 times, most recently from 971945d to 79ec0b0 Compare February 12, 2025 20:34
@ArthurHeymans ArthurHeymans marked this pull request as ready for review February 12, 2025 20:34
@mhatrevi mhatrevi requested a review from nquarton February 13, 2025 17:29
Copy link
Contributor

@nquarton nquarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be added to the existing nightly release. That would mean the two are dependent on each other and releases can't be made independently. I understand it may need to go in main so it can be scheduled, but if so, I think it should be a separate action.

Scheduled actions can only be done on the main branch, which is why a
workflow_dispatch is used.

Signed-off-by: Arthur Heymans <[email protected]>
@ArthurHeymans
Copy link
Contributor Author

I don't think this should be added to the existing nightly release. That would mean the two are dependent on each other and releases can't be made independently. I understand it may need to go in main so it can be scheduled, but if so, I think it should be a separate action.

I put it in a different file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants