Change default layers to use lowercase directories #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change directories for default layers to use lowercase output directories. While this is independently likely a better choice, it is a somewhat pragmatic, as these directory names match the legacy names of `firtool`'s extract-test-code feature (which was a custom SiFive pass for the SFC before being open-sourced in `firtool`). This will help us land an extract-test-code replacement without having to disturb build flows. Secondarily, and independently, lower case directories are likely better. There are two alternative changes which were rejected: 1. The layers could be renamed to be lowercase. Generally, it's better to have objects and classes be uppercase. 2. The automatic directory names could be mangled to be lowercase as opposed to the exact layer names. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added
API Modification
Backend Code Generation
jackkoenig
approved these changes
Nov 13, 2024
Emin017
added a commit
to Emin017/chisel-nix
that referenced
this pull request
Feb 1, 2025
Chisel will generate lowercase directoreise by default now, see: chipsalliance/chisel#4505 Signed-off-by: Qiming Chu <[email protected]>
Emin017
added a commit
to Emin017/chisel-nix
that referenced
this pull request
Feb 1, 2025
Chisel will generate lowercase directoreise by default now, see: chipsalliance/chisel#4505. Signed-off-by: Qiming Chu <[email protected]>
Avimitin
pushed a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Feb 2, 2025
Chisel will generate lowercase directoreise by default now, see: chipsalliance/chisel#4505. Signed-off-by: Qiming Chu <[email protected]>
Avimitin
pushed a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Feb 8, 2025
Chisel will generate lowercase directoreise by default now, see: chipsalliance/chisel#4505. Signed-off-by: Qiming Chu <[email protected]>
unlsycn
added a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Feb 9, 2025
* [build] bump to mill 0.12.5 and refactor build scripts Signed-off-by: unlsycn <[email protected]> * [nix] remove projectDependencies scripts Signed-off-by: unlsycn <[email protected]> * [nix] fix add-determinsim and mill-deps building on darwin * bump add-determinism to unstable-2024-11-12 and add patches for darwin * fix mill-deps building on darwin (The caches dir on darwin is `$TMPDIR/Library/Caches/Coursier`) * [nix] remove fix-darwin.patch and use fetchpatch fetchpatch from https://github.com/Emin017/add-determinism/commits/fix-darwin/ Signed-off-by: Qiming Chu <[email protected]> * [nix] Use determinism to handle hash mismatch in chisel publishLocal Signed-off-by: Qiming Chu <[email protected]> * [nix] differentiate hash for darwin in gcd.nix Signed-off-by: Qiming Chu <[email protected]> * [nix] change layers folders to use lowercase directories Chisel will generate lowercase directoreise by default now, see: chipsalliance/chisel#4505. Signed-off-by: Qiming Chu <[email protected]> * [ci] fix mill env * [nix] remove local packed add-determinism and use upstream version Signed-off-by: Qiming Chu <[email protected]> * [nix] use mill flow overlay Signed-off-by: unlsycn <[email protected]> * [doc] update readme.md Signed-off-by: unlsycn <[email protected]> --------- Signed-off-by: unlsycn <[email protected]> Signed-off-by: Qiming Chu <[email protected]> Co-authored-by: Qiming Chu <[email protected]> Co-authored-by: Avimitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change directories for default layers to use lowercase output directories. While this is independently likely a better choice, it is a somewhat pragmatic, as these directory names match the legacy names of
firtool's extract-test-code feature (which was a custom SiFive pass for the SFC before being open-sourced infirtool). This will help us land an extract-test-code replacement without having to disturb build flows. Secondarily, and independently, lower case directories are likely better.There are two alternative changes which were rejected:
The layers could be renamed to be lowercase. Generally, it's better to have objects and classes be uppercase.
The automatic directory names could be mangled to be lowercase as opposed to the exact layer names.
Release Notes
Change directories for default layers to be lowercase.