Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module prefixing to BaseModule definitions #4509

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

  • BaseModule.localModulePrefix can be used to set a prefix for the module and its children.
  • BaseModule.localPrefixAppliesToSelf (defaults to true) allows the module to exclude itself from the prefix.
  • localModulePrefix composes with prefixes added via withModulePrefix.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Nov 14, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Nov 14, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) November 14, 2024 22:05
* BaseModule.localModulePrefix can be used to set a prefix for the
  module and its children.
* BaseModule.localPrefixAppliesToSelf (defaults to true) allows the
  module to exclude itself from the prefix.
* localModulePrefix composes with prefixes added via withModulePrefix.
@jackkoenig jackkoenig merged commit 9c2498a into main Nov 14, 2024
14 checks passed
@jackkoenig jackkoenig deleted the module-prefix-definition branch November 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants