Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong mill source layout #4511

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

unlsycn
Copy link
Contributor

@unlsycn unlsycn commented Nov 16, 2024

Trait HasScala2Plugin and HasScala2MacroAnno extending CrossSbtModule will override the mill sources with SBT's folder layout and it will break the modules with mill's default source layout like LitUtility and PanamaConverter.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Trait HasScala2Plugin and HasScala2MacroAnno extending CrossSbtModule
will override the mill sources with SBT's folder layout and it will
break the modules with mill's default source layout like LitUtility
and PanamaConverter.

Signed-off-by: unlsycn <[email protected]>
@sequencer sequencer added the Bugfix Fixes a bug, will be included in release notes label Nov 16, 2024
@unlsycn unlsycn marked this pull request as ready for review November 16, 2024 13:23
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 17, 2024
@chiselbot chiselbot merged commit 32fa608 into chipsalliance:main Nov 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants