Define term.js as an AMD module when AMD is defined #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the Node style modules that term.js already supports this commit adds support for AMD browser modules. The module usage is auto-detected.
stefwalter
added a commit
to stefwalter/cockpit
that referenced
this pull request
Mar 10, 2016
We'll use a forked version of term.js for now. It includes the following pull requests not yet merged upstream: * Support for Content-Security-Policy chjj/term.js#115 * Define itself as an AMD module when running under AMD chjj/term.js#116 https://github.com/cockpit-project/term.js
dperpeet
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Mar 11, 2016
We'll use a forked version of term.js for now. It includes the following pull requests not yet merged upstream: * Support for Content-Security-Policy chjj/term.js#115 * Define itself as an AMD module when running under AMD chjj/term.js#116 https://github.com/cockpit-project/term.js Reviewed-by: Dominik Perpeet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the Node style modules that term.js already supports
this commit adds support for AMD browser modules. The module usage
is auto-detected.