Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#26) Use milestone for license URL replacement #27

Merged

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the relpacement used when creating a license URL
to make use of the Build Version Milestone, instead of the tag name.

Motivation and Context

This is done as in certain scenarios the tag name is an empty string and will
cause an invalid URL to be generated. This causes problems when doing a
release of the product, and thus changing to the milestone is more
appropriate.

Testing

  1. Create a temporary tag locally
  2. Run the build using ´build.bat´
  3. Verify the created package has the correct license URL (with the name of the tag in the URL)

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change) (Build Related).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #26

This updates the relpacement used when creating a license URL
to make use of the Build Version Milestone, instead of the tag name.

This is done as in certain scenarios the tag name is an empty string and will
cause an invalid URL to be generated. This causes problems when doing a
release of the product, and thus changing to the milestone is more
appropriate.
@AdmiringWorm AdmiringWorm self-assigned this Jan 18, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 January 18, 2024 13:56
@AdmiringWorm
Copy link
Member Author

To note, once merged this should also be cherry picked into the master branch

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 698a713 into chocolatey-community:develop Jan 18, 2024
1 check passed
@gep13
Copy link
Member

gep13 commented Jan 18, 2024

@AdmiringWorm thanks for getting that updated!

@AdmiringWorm AdmiringWorm deleted the fix-license-replacement branch January 18, 2024 14:15
AdmiringWorm pushed a commit to AdmiringWorm/chocolatey-community-validation that referenced this pull request Jan 18, 2024
…nse-replacement

(chocolatey-community#26) Use milestone for license URL replacement

(cherry picked from commit 698a713)
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this pull request Dec 11, 2024
* master:
  (maint) Fix incorrect label used in config
  Merge pull request chocolatey-community#27 from AdmiringWorm/fix-license-replacement
  (maint) Update issue comment for GRM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a release is being created the license URL generated is incorrect
2 participants