Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Enable Sources before Pushing #288

Merged
merged 1 commit into from
Jan 8, 2025
Merged

(fix) Enable Sources before Pushing #288

merged 1 commit into from
Jan 8, 2025

Conversation

JPRuskin
Copy link
Member

@JPRuskin JPRuskin commented Jan 8, 2025

Description Of Changes

This change ensures that sources are enabled before we attempt to push if they are disabled.

Motivation and Context

Chocolatey sources that are disabled need to be enabled before we can rely on their stored credentials.

Testing

Tested locally.

  • Deployed branch
  • Ran internalize... cloudflared [success]
  • Ran internalize... firefox [success]
  • Pushed an old version of dbatools to the test repository
  • Ran Update test repository... [success]

image

Operating Systems Testing

  • Windows Server 2022 (local)

Change Types Made

  • Bug fix (non-breaking change).
  • [ ] Feature / Enhancement (non-breaking change).
  • [ ] Breaking change (fix or feature that could cause existing functionality to change).
  • [ ] Documentation changes.
  • PowerShell code changes.

Change Checklist

  • [ ] Requires a change to the documentation.
  • [ ] Documentation has been updated.
  • [ ] Tests to cover my changes, have been added. (these will come in a later branch)
  • All new and existing tests passed?
  • [ ] PowerShell code changes: PowerShell v3 compatibility checked?

Chocolatey sources that are disabled need to be enabled before we can rely on their credentials.

This change ensures that sources are enabled before we attempt to push if they are disabled.
@JPRuskin JPRuskin requested a review from steviecoaster January 8, 2025 15:45
Copy link
Contributor

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine!

@steviecoaster steviecoaster merged commit 15db143 into main Jan 8, 2025
15 checks passed
@steviecoaster steviecoaster deleted the fixJenkins branch January 8, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants