Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] adding function that attempts to do some sort of clustering #21
base: master
Are you sure you want to change the base?
[WIP] adding function that attempts to do some sort of clustering #21
Changes from 1 commit
04f1d2b
90764a3
07337e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is to be called from
analyze_run
? (as we do forsave_representative_snapshots
here?) If so, we'll have access to the Works extracted from theglobals.csv
files.Assuming that the existence of a
globals.csv
implies that a trajectory was also written, you should be able to get the existing trajectories by passing aworks: List[Work]
argument down to this function and using something likeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! It should be (eventually) in the place of
save_snapshots
as it's just a slightly more comprehensive way to do the same thing. Do you think works is a better kwargs, or a list of clones and gens?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe it would be better to take the clones/gens. If we want to do it at random, we can put random values into the function, but we may also want to cluster ALL of GEN0, so maybe it makes better sense to have the choosing clone/gen logic outside the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing just a list of clones/gens sounds reasonable to me (especially if we're not actually going to use the works here). The
list_results
function inlib.py
gets a listing of clones and gens given a project path and run.Actually, it might make sense to change things around a little bit to call
list_path
just once inanalyze_run
, and pass the result to bothextract_works
and to this function. (We can always clean this up later, too)