Fix forcefield generators to work with latest ParmEd #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en asking ParmEd to convert to OpenMMParameterSet
…,0) due to dirty install
This was referenced Apr 16, 2018
There was a problem hiding this comment.
Thanks for the fix. This looks good, but I wouldn't merge this until parmed is fixed, and we can verify it works with the new version.
I don't know for sure if the current code already tests well enough, but perhaps we could add some version of my minimal example as a test so we can catch problems in the future.
|
Agreed! We should also pin to the latest ParmEd after it is released and add a check in this method to ensure a recent version of ParmEd is installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ParmEd/ParmEd#977
Note that this also requires ParmEd/ParmEd#978