-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Pre-generate residue templates #492
Conversation
ncmc updates, no alchemy
…ruct atom map problem
update master (was 80 commits behind before)
… to it in FFAllAngleGeometryEngine
… on fixing KinaseInhibitorTestSystem
…stem to use generateForcefieldFromMolecules
…smiles through small molecule engine
…h ExpandedEnsembler's call to propose
@@ -1714,7 +1714,7 @@ def __init__(self, constraints=app.HBonds, premapped_json_dict=None, **kwargs): | |||
forcefield = app.ForceField(gaff_xml_filename, 'tip3p.xml', clinical_kinase_inhibitors_filename) | |||
d_smiles_to_oemol = {smiles : smiles_to_oemol(smiles, "MOL%d" % i)for i, smiles in enumerate(molecules)} | |||
|
|||
## Generate and ffxml, then add to forcefield | |||
# ## Generate and ffxml, then add to forcefield |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to uncomment this code and pre-generate the parameters, or did you not want to pre-generate the parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That code is commented so whoever is looking at it can reproduce the error I was getting when loading the ffxml I already generated (https://github.com/choderalab/perses/blob/residue_templates/perses/data/clinical-kinase-inhibitors.xml). However, I wasn't sure if the problem was related to loading the template or generating the template. Therefore, to better understand the problem (and debug), I kept the code I used to generate the templates in there. Feel free to uncomment it if you think the problem occurs while generating the templates.
Marking this as "DO NOT MERGE" so we can pull changes into a new PR. |
When instantiating
KinaseInhibitorTestSystem
, this version ofPerses
currently loads a ffxml containing Imatinib (MOL0), Dasatinib (MOL1), Nilotinib (MOL2), and Bosutinib (MOL3). This is located at data/clinical-kinase-inhibitors.xml or https://github.com/choderalab/perses/blob/residue_templates/perses/data/clinical-kinase-inhibitors.xmlHowever, even though the ffxml seems to contain the right residue templates, the templates cannot be found/matched:
I'm not sure if this is because the ffxml was generated incorrectly or if there is an issue with template matching.
To modify the code so that it pre-generates templates again (instead of loading the ffxml):
SmallMoleculeLibraryTestSystem
oftestsystems.py
, uncomment lines 1717-1724https://github.com/choderalab/perses/blob/residue_templates/perses/tests/testsystems.py#L1717-L1724
SmallMoleculeLibraryTestSystem
oftestsystems.py
, modify lines 1713-1714 such thatapp.Forcefield
only takes ingaff_xml_filename
andtip3p.xml
Note: Use the latest commit from this
openmoltools
PR: choderalab/openmoltools#282Note: The data/clinical-kinase-inhibitors.csv in this version of
Perses
contains only a subset of all the clinical kinase inhibitors found in master.