Use ROSControlItem #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to note that this PR can be regarded as a part of #1 : this PR consists of critical changes in there. |
|
Thank you for your cooperation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the Tank sample to use the latest choreonoid plugin for ros_control: currently the sample depends on choreonoid_ros_control, and the changed settings uses ROSControlItem, which is merged to ros_control from choreonoid_ros_control.
Additionally, this PR removes
--inorderoptions of xacro, which was removed in ROS melodic.This PR is expected to resolve #2 .