Remove 'post comment' step from benchmark action #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow fails with a permission error when a pull request is opened from an external repository. This can be fixed by adding a personal token to the workflow, but removing the step is easier
|
Thanks @tompollard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pull request comes from a forked repository, the "Post results to pull request" action in the Benchmark.yml workflow fails (e.g. see: #105).
The issue is that the GITHUB_TOKEN provided by GitHub Actions only has read permissions. This can be fixed by adding a custom token, but it is quicker and easier to remove the post results step, which is what I am doing here!
The benchmark results should still be posted in the output of the github action, so it's not a big loss.