i18n: Set up "Direct messages" page title for translation

chrisbobbe · Feb 6, 2024 · 880a0fe · 880a0fe
1 parent a0f4462
commit 880a0fe
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -416,5 +416,9 @@
   "userRoleUnknown": "Unknown",
   "@userRoleUnknown": {
     "description": "Label for UserRole.unknown"
+  },
+  "recentDmConversationsPageTitle": "Direct messages",
+  "@recentDmConversationsPageTitle": {
+    "description": "Title for the page of recent DM conversations"
   }
 }
diff --git a/lib/widgets/app.dart b/lib/widgets/app.dart
@@ -265,7 +265,7 @@ class HomePage extends StatelessWidget {
           ElevatedButton(
             onPressed: () => Navigator.push(context,
               RecentDmConversationsPage.buildRoute(context: context)),
-            child: const Text("Direct messages")),
+            child: Text(zulipLocalizations.recentDmConversationsPageTitle)),
           if (testStreamId != null) ...[
             const SizedBox(height: 16),
             ElevatedButton(

diff --git a/lib/widgets/recent_dm_conversations.dart b/lib/widgets/recent_dm_conversations.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 
 import '../model/narrow.dart';
 import '../model/recent_dm_conversations.dart';
@@ -53,9 +54,10 @@ class _RecentDmConversationsPageState extends State<RecentDmConversationsPage> w
 
   @override
   Widget build(BuildContext context) {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     final sorted = model!.sorted;
     return Scaffold(
-      appBar: AppBar(title: const Text('Direct messages')),
+      appBar: AppBar(title: Text(zulipLocalizations.recentDmConversationsPageTitle)),
       body: SafeArea(
         // Don't pad the bottom here; we want the list content to do that.
         bottom: false,

diff --git a/test/widgets/recent_dm_conversations_test.dart b/test/widgets/recent_dm_conversations_test.dart
@@ -1,6 +1,7 @@
 import 'package:checks/checks.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:zulip/api/model/events.dart';
 import 'package:zulip/api/model/model.dart';
@@ -49,6 +50,8 @@ Future<void> setupPage(WidgetTester tester, {
   await tester.pumpWidget(
     GlobalStoreWidget(
       child: MaterialApp(
+        localizationsDelegates: ZulipLocalizations.localizationsDelegates,
+        supportedLocales: ZulipLocalizations.supportedLocales,
         navigatorObservers: navigatorObserver != null ? [navigatorObserver] : [],
         home: PerAccountStoreWidget(
           accountId: eg.selfAccount.id,