Skip to content

Commit

Permalink
unread_count_badge: Comment on some overlooked uncertainty in text color
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisbobbe committed May 4, 2024
1 parent ffb924e commit d12d75e
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions lib/widgets/unread_count_badge.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ class UnreadCountBadge extends StatelessWidget {
fontSize: 16,
height: (18 / 16),
fontFeatures: [FontFeature.enable('smcp')], // small caps

// From the Figma:
// https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=171-12359&mode=design&t=JKrw76SGUF51nSJG-0
// TODO or, when background is stream-colored, follow Vlad's replit:
// https://replit.com/@VladKorobov/zulip-sidebar#script.js
// which means:
// - in light mode use `Color.fromRGBO(0, 0, 0, 0.9)`
// - in dark mode use `Color.fromRGBO(255, 255, 255, 0.9)`
// The web app doesn't (yet?) use stream-colored unread markers
// so we can't take direction from there.
color: Color(0xFF222222),
).merge(weightVariableTextStyle(context,
wght: bold ? 600 : null)),
Expand Down

0 comments on commit d12d75e

Please sign in to comment.