Skip to content

Commit

Permalink
ui [nfc]: Comment on some ways we can follow new Figma but haven't yet
Browse files Browse the repository at this point in the history
I don't expect these to be fundamentally hard, they're just not
really trivial; we'll leave them for later.
  • Loading branch information
chrisbobbe committed Jun 17, 2024
1 parent 1d8c599 commit f0c1db7
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/widgets/theme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ ThemeData zulipThemeData(BuildContext context) {
scrolledUnderElevation: 0,
backgroundColor: const Color(0xfff5f5f5), // `bg-top-bar` in Figma

// TODO match layout to Figma
actionsIconTheme: const IconThemeData(
color: Color(0xff666699), // `icon` in Figma
),
Expand All @@ -35,6 +36,10 @@ ThemeData zulipThemeData(BuildContext context) {
.merge(weightVariableTextStyle(context, wght: 600)),
titleSpacing: 4,

// TODO Figma has height 42; we should try `toolbarHeight: 42` and test
// that it looks reasonable with different system text-size settings.
// Also the back button will look too big and need adjusting.

shape: const Border(bottom: BorderSide(
color: Color(0x33000000), // `border-bar` in Figma
strokeAlign: BorderSide.strokeAlignInside, // (default restated for explicitness)
Expand Down

0 comments on commit f0c1db7

Please sign in to comment.