New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check internal methods called config #10

Merged

chrisdicarlo merged 2 commits into chrisdicarlo:main from moshe-autoleadstar:patch-1

Oct 7, 2024

Contributor

moshe-autoleadstar commented Oct 6, 2024

class MyClass
{
    public function doSomething()
    {
        return $this->config('key');
    }

    private function config(string $key)
    {
        return config('path.to.' . $key);
    }
}

Before - fails
After - passes


          Don't check internal methods called config

b68df8a

chrisdicarlo self-assigned this


          Add missing test

9dc381f

Owner

chrisdicarlo commented Oct 7, 2024

Good catch! Thanks for the PR!

chrisdicarlo merged commit 1b360a0 into chrisdicarlo:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet