-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Regular/Bold/Italic based on textStyle attribute #195
base: master
Are you sure you want to change the base?
Conversation
If the fontPath is invalid in assets we postfix them corresponding to original type face style and try to set it
Thanks for this, this looks interesting. I've been searching for a better way of building the font families, actually creating Typeface families natively that way we would not need to do any logic ourselves. |
I would love to see this feature implemented! |
Very nice feature. When you plan to release a new version with this? |
Very nice and useful feature! |
This pull request is still open. When you release this feature? Thank you |
This would be good on future release. Plz merge |
Any info about this? It’s more than one year old. |
By the way:
Also if - say - bold is not present we should fallback to regular. @chrisjenx I have read elsewhere that you were planning to use a different technique. Are you still working on that? Can we help in some way? |
Is there any news regarding this PR or support for setting multiple font types? |
I would fork and use this yourself, we are going to do another mechanism to do this. |
Thanks for the info. |
@chrisjenx Is there any update on the implementation of this feature? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please approve this PR
This kind of thing makes more sense to use with either https://github.com/InflationX/ViewPump or the native supported font's built into Google Play Services now. |
No description provided.