Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof P32-P35_P72-P75 #614 (PR 2/2) #784

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ngsctt
Copy link

@ngsctt ngsctt commented Oct 25, 2020

PR 2 of 2, resolves #614, covering pages 0632–0650

I've treated indentation and empty lines within comment blocks the same as in #782.

The only major concerns were:

  1. At 5513 (page 633), it looks like RA1 has been misspelt in the comment as RAI. I've corrected it, but I'm not completely 100% confident the character is a letter I instead of a poorly-printed digit 1
  2. At 5769 and 5783 (both on page 638), the code has a (subroutine?) named K10RK2, however looking at both places in the scan, I'm pretty confident it's the letter O and not the digit 0. I've corrected it to be K1ORK2 in both places.

Corrections made

  • Page 632
    • P5000 (L645) replace *s with .s; add spaces to match alignment in scan
    • 5417 (L672) remove space not in scan
    • 5419 (L676) add spaces to match alignment in scan; remove extra hyphen
    • 5420 (L678) add spaces to match alignment in scan
    • 5422 (L682) add spaces to match alignment in scan
    • 5423 (L684) remove extra hyphen
    • 5424 (L686) add spaces to match alignment in scan
    • 5502 (L694) (un)correct INDICATORINDICATR
  • Page 633
    • 5504 (L697) remove comma not in scan
    • 5505 (L698) remove comma, remove space not in scan
    • 5513 (L706) (un)correct RA1RAI; realign whitespace in comment
    • 5515 (L708) realign whitespace in comment
    • 5518 (L711) realign whitespace in comment
    • 5520 (L713) realign whitespace in comment
    • 5523 (L716) realign whitespace in comment
    • 5525 (L718) realign whitespace in comment
    • 5528 (L721) realign whitespace in comment
    • 5529 (L722) realign whitespace in comment
    • 5530 (L723) remove tab not reflected in scan
    • 5531 (L724) realign whitespace in comment
    • 5536 (L729) realign whitespace in comment
    • 5538 (L731) realign whitespace in comment
  • Page 634
    • 5577 (L771) remove space in comment not in scan
  • Page 635
    • 5610 (L810) realign whitespace in comment
    • 5614 (L814) correct B38B36; realign whitespace in comment
    • 5625 (L825) realign whitespace in comment
    • 5632 (L832) correct B-14B-45; realign whitespace in comment
    • 5641 (L841) realign whitespace in comment
    • 5643 (L843) remove space in comment not in scan; realign whitespace in comment
  • Page 636 — no discrepancies found
  • Page 637
    • 5744 (L937) remove space in comment not in scan
    • 5747 (L940) remove spaces in comment not in scan; realign whitespace in comment
    • 5749 (L942) realign whitespace in comment
    • 5750 (L943) realign whitespace in comment
    • 5751 (L944) realign whitespace in comment
    • 5753 (L946) realign whitespace in comment
    • 5754 (L947) realign whitespace in comment
    • 5755 (L948) remove spaces in comment not in scan; realign whitespace in comment
    • 5756 (L949) realign whitespace in comment
  • Page 638
    • 5757 (L951) realign whitespace in comment
    • 5759 (L953) realign whitespace in comment
    • 5762 (L956) remove spaces in comment not in scan
    • 5764 (L958) remove spaces in comment not in scan; realign whitespace in comment
    • 5766 (L960) realign whitespace in comment
    • 5767 (L961) remove spaces in comment not in scan; realign whitespace in comment
    • 5769 (L963) correct K10RK2K1ORK2 in code
    • 5783 (L977) correct K10RK2K1ORK2 in code; realign whitespace in comment
    • 5785 (L979) remove space in comment not in scan
    • 5786 (L980) realign whitespace in comment
    • 5787 (L981) realign whitespace in comment
    • 5788 (L982) remove space in comment not in scan
    • 5797 (L991) remove spaces in comment not in scan
    • 5801 (L995) remove spaces in comment not in scan; realign whitespace in comment
    • 5803 (L997) move comment up from line below; realign whitespace
    • 5805 (L999) move comment up from line below; realign whitespace
  • Page 639
    • 5807 (L1002) realign whitespace in comment
    • 5812 (L1007) realign whitespace in comment
    • 5813 (L1008) remove spaces in comment not in scan; realign whitespace in comment
    • 5814 (L1009) realign whitespace in comment
    • 5816 (L1011) realign whitespace in comment
    • 5817 (L1012) remove spaces in comment not in scan
    • 5822 (L1017) realign whitespace in comment
    • 5825 (L1020) realign whitespace in comment
    • 5828 (L1023) realign whitespace in comment
    • 5829 (L1024) realign whitespace in comment
  • Page 640
    • 5892 (L1088) move comment down from line above
  • Page 641
    • 5914 (L1111) remove space in code not in scan
    • 5920 (L1117) remove space in code not in scan
  • Page 642
    • P6000 (L1154) replace *s with .s; add spaces to match alignment in scan
    • Add empty line (L1157) after R6050
  • Page 643
    • P6200 (L1191) replace *s with .s; add spaces to match alignment in scan
  • Page 644
    • P7000 (L1203) replace *s with .s; add space to match alignment in scan
  • Page 645
    • P7400 (L1221) replace *s with .s; add space to match alignment in scan
    • Add empty line (L1224) after R7450
  • Page 646
    • P7800 (L1245) replace *s with .s; add space to match alignment in scan
  • Page 647
    • P8000 (L1260) replace *s with .s; add spaces to match alignment in scan
    • Add empty line (L1263) after R8050
  • Page 648
    • 8143 (L1312) realign whitespace in comment
    • 8145 (L1314) realign whitespace in comment
    • 8152 (L1321) remove space in code not in scan
    • 8153 (L1322) realign whitespace in comment
    • 8155 (L1324) realign whitespace in comment
    • 8156 (L1325) realign whitespace in comment
    • 8157 (L1326) realign whitespace in comment
    • 8161 (L1330) realign whitespace in comment
    • 8162 (L1331) realign whitespace in comment
    • 8166 (L1335) realign whitespace in comment
    • 8167 (L1336) realign whitespace in comment
    • 8168 (L1337) remove space in code not in scan
    • 8169 (L1338) realign whitespace in comment
    • 8175 (L1344) remove space in code not in scan
    • 8176 (L1345) realign whitespace in comment
    • 8179 (L1348) realign whitespace in comment
  • Page 649
    • 8199 (L1362) remove extra hyphen in comment
  • Page 650
    • P8201 (L1366) replace *s with .s; add spaces to match alignment in scan
    • Add empty line (L1369) after R8202
    • R8203 (L1370) realign whitespace
    • R8204 (L1371) realign whitespace

@ngsctt ngsctt marked this pull request as draft October 25, 2020 03:12
ngsctt added 18 commits October 25, 2020 14:13
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0632.jpg

P5000 (L645) replace `*`s with `.`s; add spaces to match alignment in scan
5417 (L672) remove space not in scan
5419 (L676) add spaces to match alignment in scan; remove extra hyphen
5420 (L678) add spaces to match alignment in scan
5422 (L682) add spaces to match alignment in scan
5423 (L684) remove extra hyphen
5424 (L686) add spaces to match alignment in scan
5502 (L694) (un)correct "INDICATOR" → "INDICATR"
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0633.jpg

5504 (L697) remove comma not in scan
5505 (L698) remove comma, remove space not in scan
5513 (L706) (un)correct "RA1" → "RAI"; realign whitespace in comment
5515 (L708) realign whitespace in comment
5518 (L711) realign whitespace in comment
5520 (L713) realign whitespace in comment
5523 (L716) realign whitespace in comment
5525 (L718) realign whitespace in comment
5528 (L721) realign whitespace in comment
5529 (L722) realign whitespace in comment
5530 (L723) remove tab not reflected in scan
5531 (L724) realign whitespace in comment
5536 (L729) realign whitespace in comment
5538 (L731) realign whitespace in comment
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0635.jpg

5610 (L810) realign whitespace in comment
5614 (L814) correct "B38" → "B36"; realign whitespace in comment
5625 (L825) realign whitespace in comment
5632 (L832) correct "B-14" → "B-45"; realign whitespace in comment
5641 (L841) realign whitespace in comment
5643 (L843) remove space in comment not in scan; realign whitespace in comment
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0637.jpg

5744 (L937) remove space in comment not in scan
5747 (L940) remove spaces in comment not in scan; realign whitespace in comment
5749 (L942) realign whitespace in comment
5750 (L943) realign whitespace in comment
5751 (L944) realign whitespace in comment
5753 (L946) realign whitespace in comment
5754 (L947) realign whitespace in comment
5755 (L948) remove spaces in comment not in scan; realign whitespace in comment
5756 (L949) realign whitespace in comment
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0638.jpg

5757 (L951) realign whitespace in comment
5759 (L953) realign whitespace in comment
5762 (L956) remove spaces in comment not in scan
5764 (L958) remove spaces in comment not in scan; realign whitespace in comment
5766 (L960) realign whitespace in comment
5767 (L961) remove spaces in comment not in scan; realign whitespace in comment
5769 (L963) correct "K10RK2" → "K1ORK2" in code
5783 (L977) correct "K10RK2" → "K1ORK2" in code; realign whitespace in comment
5785 (L979) remove space in comment not in scan
5786 (L980) realign whitespace in comment
5787 (L981) realign whitespace in comment
5788 (L982) remove space in comment not in scan
5797 (L991) remove spaces in comment not in scan
5801 (L995) remove spaces in comment not in scan; realign whitespace in comment
5803 (L997) move comment up from line below; realign whitespace
5805 (L999) move comment up from line below; realign whitespace
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0639.jpg

5807 (L1002) realign whitespace in comment
5812 (L1007) realign whitespace in comment
5813 (L1008) remove spaces in comment not in scan; realign whitespace in comment
5814 (L1009) realign whitespace in comment
5816 (L1011) realign whitespace in comment
5817 (L1012) remove spaces in comment not in scan
5822 (L1017) realign whitespace in comment
5825 (L1020) realign whitespace in comment
5828 (L1023) realign whitespace in comment
5829 (L1024) realign whitespace in comment
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0641.jpg

5914 (L1111) remove space in code not in scan
5920 (L1117) remove space in code not in scan
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0642.jpg

P6000 (L1154) replace `*`s with `.`s; add spaces to match alignment in scan
Add empty line (L1157) after R6050
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0643.jpg

P6200 (L1191) replace `*`s with `.`s; add spaces to match alignment in scan
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0644.jpg

P7000 (L1203) replace `*`s with `.`s; add space to match alignment in scan
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0645.jpg

P7400 (L1221) replace `*`s with `.`s; add space to match alignment in scan
Add empty line (L1224) after R7450
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0646.jpg

P7800 (L1245) replace `*`s with `.`s; add space to match alignment in scan
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0647.jpg

P8000 (L1260) replace `*`s with `.`s; add spaces to match alignment in scan
Add empty line (L1263) after R8050
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0648.jpg

8143 (L1312) realign whitespace in comment
8145 (L1314)  realign whitespace in comment
8152 (L1321) remove space in code not in scan
8153 (L1322)  realign whitespace in comment
8155 (L1324)  realign whitespace in comment
8156 (L1325)  realign whitespace in comment
8157 (L1326)  realign whitespace in comment
8161 (L1330)  realign whitespace in comment
8162 (L1331)  realign whitespace in comment
8166 (L1335)  realign whitespace in comment
8167 (L1336)  realign whitespace in comment
8168 (L1337)  remove space in code not in scan
8169 (L1338)  realign whitespace in comment
8175 (L1344) remove space in code not in scan
8176 (L1345) realign whitespace in comment
8179 (L1348) realign whitespace in comment
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0650.jpg

P8201 (L1366) replace `*`s with `.`s; add spaces to match alignment in scan
Add empty line (L1369) after R8202
R8203 (L1370) realign whitespace
R8204 (L1371) realign whitespace
@ngsctt ngsctt force-pushed the P32-P35_P72-P75_pt2 branch from d2d94ee to 9cea1c8 Compare October 25, 2020 03:13
@ngsctt ngsctt marked this pull request as ready for review October 25, 2020 03:14
@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 25, 2020
@wopian wopian self-requested a review October 25, 2020 17:23
@wopian wopian self-assigned this Oct 25, 2020
@wopian wopian added this to the Luminary099 milestone Oct 25, 2020
@wopian wopian mentioned this pull request Oct 25, 2020
@wopian
Copy link
Collaborator

wopian commented Oct 27, 2020

I've added the hacktoberfest-accepted label to ensure your contribution counts towards Hacktoberfest, as I haven't been able to review as many PRs as I had hoped over the past few days during my free time.

PRs are being throughly reviewed from oldest to newest 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof P32-P35_P72-P75
2 participants