Add predifined addressbooks #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2012 17:04
In order to add additional ways to add or delete CardDAV server, we factor out backend operations from carddav_server_save() and carddav_server_delete(). Those frontend functions have been suffixed with `_from_settings` to disambiguate them from them backend counterpart (`add_carddav_server` and `delete_carddav_server`, respectively). `carddav_server_check_connection` now explicitly receives settings instead of dircectly parsing user parameters.
A new configuration directive `carddav_default_servers` can be used to specify a list of predefined addressbooks. It supports some replacement strings in order to work with CardDAV servers that share authentication credentials with the IMAP server. In order to spot new (or deleted) predefined addressbooks, we add a new `default_server` flag to the database. This way we can ensure that we will never automatically remove user defined calendars. We also hide and prevent modifications to predefined addressbooks from the users. Closes: christian-putzke#4
|
I'll check this. But I've allready planed that feature and may check if your solution will be compatible to mine or not. But thanks anyway for your contribution! |
|
Any news ? |
|
Whoaaa!!!! Thank you very much, I needed this option, and your changes are working fine. +1 for the merge |
|
It rock´s! Thx a lot for the merge. |
| * @param array server connection parameters | ||
| * @return mixed either a CardDAV_Backend or FALSE if the connection fails | ||
| */ | ||
| private function get_backend($server) { |
There was a problem hiding this comment.
I had to change to "private function get_backend(&$server)" to have it working correctly
fmbiete
added a commit
to fmbiete/Roundcube-CardDAV
that referenced
this pull request
Feb 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements predifined addressbooks (Issue #4). Please merge!