-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose and improve the docstrings of export_od
and import_id
#473
Merged
acolomb
merged 12 commits into
christiansandberg:master
from
erlend-aasland:doc/import-and-export-od
Jul 2, 2024
Merged
Expose and improve the docstrings of export_od
and import_id
#473
acolomb
merged 12 commits into
christiansandberg:master
from
erlend-aasland:doc/import-and-export-od
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 67.68% 67.68%
=======================================
Files 26 26
Lines 3104 3104
Branches 521 521
=======================================
Hits 2101 2101
Misses 862 862
Partials 141 141
|
erlend-aasland
commented
Jun 29, 2024
Docstring changes:
|
erlend-aasland
changed the title
Expose and improve the docstrings of export_od and import_id
Expose and improve the docstrings of Jun 29, 2024
export_od
and import_id
erlend-aasland
commented
Jun 29, 2024
erlend-aasland
commented
Jul 1, 2024
erlend-aasland
commented
Jul 1, 2024
acolomb
requested changes
Jul 2, 2024
This comment was marked as resolved.
This comment was marked as resolved.
acolomb
reviewed
Jul 2, 2024
Co-authored-by: André Colomb <[email protected]>
acolomb
approved these changes
Jul 2, 2024
Thanks for the review and your insights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #472