Add Groestlcoin (GRS) #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR needs to be rebased I am happy to do that if you don't use Squash and Merge. |
|
@christsim Let us know if this PR is ok to get merged or something else needs to be fixed also |
|
@christsim Fixed conflicts and ready for review. This has been implemented and tested on Trezor: trezor@b213f7a |
|
@christsim Fixed conflicts again and ready for review. |
|
@christsim Let us know if you have a chance to review |
|
@christsim rebased on upstream to fix conflicts |
|
@christsim rebased |
gruve-p
force-pushed
the
add-grs
branch
2 times, most recently
from
27bcda3
to
2d815fa
Compare
|
@christsim rebased again |
|
@christsim Is this PR unwanted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for Groestlcoin addresses. Groestlcoin uses a new hash for the checksum of the addresses and that is imported from npm instead of including the file directly with the hash function as with Blake.
Since according to my comment on issue #10 this library only supports bech32 addresses for bitcoin, the tests for bech32 addresses have been commented out.