Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(site) Fix consent banner not rendering #766

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

Snugug
Copy link
Collaborator

@Snugug Snugug commented May 23, 2024

Description

Cookie consent banner was not rendering because it relies on an external JS tag that wasn't properly being pulled in. It now is.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ensure your PR title matches the following format: 🐛|🆕|📝|♻️|💎|🐎|📌(scope) subject. Subject must be written in English, start with a capital letter, can contain letters, spaces, numbers, dashes, commas, and dots, and must not end with a period or extra whitespace. See our commit convention for emoji descriptions, scopes and their descriptions, and full examples.

@Snugug Snugug requested a review from a team as a code owner May 23, 2024 15:58
@Snugug Snugug merged commit fc05fbc into main May 23, 2024
7 of 8 checks passed
@Snugug Snugug deleted the hotfix/cookie-consent branch May 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant