This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add git-salt lib and git script #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a general observation, not regarding this PR: the |
|
@ussuri yes it is confusing, Ideally they should not be part of repository and should be hosted elsewhere. We should rename them may be |
| @@ -55,6 +55,10 @@ module.exports = function(grunt) { | |||
|
|
|||
| mainsrc += '</head>\n'; | |||
| mainsrc += '<body>\n'; | |||
|
|
|||
| // Div where addons embedding code live. | |||
| mainsrc += '<div id="addons"></div>'; | |||
There was a problem hiding this comment.
This task is supposed to be generic, so we should not have this here. Can't we create the 'div' manually if it does not exist (in the code that creates the sub-elements)?
|
@rpaquay PTAL thanks. |
| }); | ||
|
|
||
| function genMessageId() { | ||
| messageId++; |
| /** | ||
| * Remove the NaCl module from the page. | ||
| */ | ||
| GitSalt.prototype.removeModule = function() { |
There was a problem hiding this comment.
I don't see any call to this function, does this mean we leak a git object at each invocation?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
gitscript and route the commands to appropriate API.stdioandstderrcorrectly.@rpaquay