Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update internal references in test imports #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iontodd
Copy link

@iontodd iontodd commented Nov 22, 2024

This pull request fixes internal references in test imports, allowing external contributors to run the test files without encountering import errors. Updated imports now follow the patterns observed in other test files in the same directory.

Changes:

  • Replaced internal-only imports with public equivalents in test files.
  • Updated references to align with project conventions.
  • Ensured that tests run successfully after the changes.

@iontodd
Copy link
Author

iontodd commented Nov 22, 2024

The smallest possible change that will achieve this goal is to modify the imports from:
from google3.third_party.chronicle.cli import mock_test_utility to
import mock_test_utility

I'm open to this too, I just tried to align the references to similar files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant