Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/scroll select toggle prop #290

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

eric-norcross
Copy link

Allows the user to explicitly set auto-select on scroll via a prop.

Currently in src/VueCtkDateTimePicker/_subs/PickersContainer/_subs/TimePicker.vue, the setTimeout method on 390 in the initPositionView () method overrides the initial config by explicitly setting this.noScrollEvent = false.

The feature branch corrects that by allowing a user to pass in a boolean prop with scroll-select and establishes the method getNoScrollEvent() which can be used for future customization of the property. The original config is currently commented out in that method; e.g.:

getNoScrollEvent () {
    // This is (essentially) the original implementation
    // if (this.scrollSelect) {
    //     return !!(this.value && !this.inline)
    // }

    return !this.scrollSelect
}

Additionally, documentation and examples have been updated to reflect this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants