Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dispatcher to check if an arg extends the varity.ref_gene.GeneAnnotationIndex protocol #106

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix the dispatcher to check if an arg extends the varity.ref_gene.GeneAnnotationIndex protocol #106

merged 1 commit into from
Sep 30, 2024

Conversation

federkasten
Copy link
Member

I have updated some dispatchers to check if an argument is not an instance of varity.ref_gene.RefGeneIndex record, but extends varity.ref_gene.GeneAnnotationIndex protocol.

@federkasten federkasten requested a review from k-kom September 30, 2024 07:40
@federkasten federkasten self-assigned this Sep 30, 2024
k-kom
k-kom approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@k-kom k-kom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked it. I should have added some tests to pass an arbitrary GeneAnnotationIndex 😞

It looks like there are no implementations depending on the RefGeneIndex other than the code you fixed. Thank you for the fix!

@k-kom k-kom merged commit bef787d into master Sep 30, 2024
30 checks passed
@k-kom k-kom deleted the fix/gene-annotation-index branch September 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-kom k-kom k-kom approved these changes

Assignees

@federkasten federkasten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federkasten @k-kom