Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix around ter codon variant #116

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

nokara26
Copy link
Contributor

@nokara26 nokara26 commented Jan 27, 2025

I fixed protein indel and extension to return variant more precisely.

@nokara26 nokara26 requested a review from federkasten January 27, 2025 01:23
@nokara26 nokara26 self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.04%. Comparing base (1663bc4) to head (ceeedf9).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/varity/vcf_to_hgvs/protein.clj 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   48.13%   48.04%   -0.09%     
==========================================
  Files          16       16              
  Lines        2273     2277       +4     
  Branches       72       72              
==========================================
  Hits         1094     1094              
- Misses       1107     1111       +4     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nokara26 nokara26 changed the title Fix around ter codon protein variant Fix around ter codon variant Jan 27, 2025
Copy link
Member

@federkasten federkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick bug fix! LGTM 🙆‍♂️

@federkasten federkasten merged commit 4847fa7 into master Jan 28, 2025
31 checks passed
@federkasten federkasten deleted the fix/fix-around-ter-codon-protein-variant branch January 28, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants