Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream and downstream sequence of sequence-info and tweak frameshift process #80

Closed
wants to merge 2 commits into from

Conversation

nokara26
Copy link
Contributor

@nokara26 nokara26 commented Oct 27, 2023

I fixed the sequence-info and frameshift alt sequence because error occurred when gene is transcribed from reverse strand and variant includes stop codon and upstream sequence from cds.

I found upstream and downstream sequence is not corrected when deletion is extended to outside of cds.
So I fix upstream sequence from cds-start and downstream sequence from cds-end and tweak frameshift process.

I executed lein run and lein run :slow and I confirmed all tests are passed.

@nokara26 nokara26 requested a review from federkasten October 27, 2023 01:34
@nokara26 nokara26 self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #80 (7b0f275) into master (493bb81) will increase coverage by 0.66%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   45.66%   46.32%   +0.66%     
==========================================
  Files          16       16              
  Lines        2006     2055      +49     
  Branches       65       68       +3     
==========================================
+ Hits          916      952      +36     
- Misses       1025     1035      +10     
- Partials       65       68       +3     
Files Coverage Δ
src/varity/vcf_to_hgvs/protein.clj 33.81% <52.94%> (+5.36%) ⬆️

@nokara26
Copy link
Contributor Author

Close this issue because I created new issue about this problem.
#81

@nokara26 nokara26 closed this Oct 31, 2023
@federkasten federkasten deleted the fix/seq-info-and-frameshift branch December 23, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant