Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and generalize overlap-exon-intron-boundary? #93

Conversation

federkasten
Copy link
Member

I have made some updates to the #92. Specifically, I have refactored and generalized the 'overlap-exon-intron-boundary?' function using diff-bases and added tests.

@federkasten federkasten requested a review from nokara26 February 1, 2024 10:24
@federkasten federkasten self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0587070) 46.79% compared to head (7e227e8) 46.93%.

Files Patch % Lines
src/varity/vcf_to_hgvs/protein.clj 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                 Coverage Diff                                  @@
##           fix/fix-exon-intron-overlap-and-ini-site-variant      #93      +/-   ##
====================================================================================
+ Coverage                                             46.79%   46.93%   +0.14%     
====================================================================================
  Files                                                    16       16              
  Lines                                                  2122     2124       +2     
  Branches                                                 72       71       -1     
====================================================================================
+ Hits                                                    993      997       +4     
+ Misses                                                 1057     1056       -1     
+ Partials                                                 72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nokara26 nokara26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nokara26 nokara26 merged commit 2adaed8 into fix/fix-exon-intron-overlap-and-ini-site-variant Feb 2, 2024
32 checks passed
@nokara26 nokara26 deleted the refactor/overlap-exon-intron-boudary branch February 2, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants