Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Darkmode #204

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update Darkmode #204

wants to merge 4 commits into from

Conversation

death7654
Copy link
Contributor

-Improves visuals
-Improves contrast
-Update 'Chrultrabook-Controller' app name to 'Chrultrabook-Tools'
-Add A Placeholder To The Search Bar In Supported Devices
-Match Search Bar Styling to Nav Search Bar in Supported Devices
-Make Danger Tip Have Better Contrast
-Make Nav Items Larger for better Accessibility

Before
image
image

After
image
image

@death7654
Update Darkmode
809bb43 
-Improves visuals
-Improves contrast
-Update 'Chrultrabook-Controller' app name to 'Chrultrabook-Tools'
@death7654 death7654 marked this pull request as ready for review September 15, 2024 06:54
@death7654
Copy link
Contributor Author

This is a continuation of https://github.com/chrultrabook/docs/pull/186. However, I am unable to reopen it as i force pushed my local changes to the cloud.

@ninelore
Copy link
Member

Please do not merge prior to a Lighthouse check

@death7654
Copy link
Contributor Author

Lighthouse checks report no changes in accessibility, seo, or best practices.

@ninelore
Copy link
Member

Lighthouse checks report no changes in accessibility, seo, or best practices.

Pls send full html report

@death7654
Copy link
Contributor Author

Lighthouse checks report no changes in accessibility, seo, or best practices.

Pls send full html report

sent in discord

@death7654
Copy link
Contributor Author

download.pdf
download2.pdf

Download2 refers to the updated CSS variables and placeholder changes

@MrChromebox
Copy link
Collaborator

personally, I think the changes in color and contrast make things far less readable, I'm not a fan at all

ninelore
ninelore requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo font changes

tip, warning and danger font colors could use more contrast in both dark and light mode

@death7654
Improve Darkmode and Lightmode Colors
6ef342e 
-Improves contrast between elements
-makes a darker darkmode
-adds a placeholder in 'supported devices'
-makes the searchbar in 'supported devices' look more professional
-Update 'Chrultrabook-Controller' app name to 'Chrultrabook-Tools'
@death7654
Merge branch 'darkmode' of https://github.com/death7654/ChrultrabookDocs
8051a8a 
 into darkmode
@death7654
fix text not showing up in dark mode.
44a1e94
@death7654
Copy link
Contributor Author

personally, I think the changes in color and contrast make things far less readable, I'm not a fan at all

How are the updated colors?

image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanaobrien ethanaobrien Awaiting requested review from ethanaobrien

@MrChromebox MrChromebox Awaiting requested review from MrChromebox

@mine-man3000 mine-man3000 Awaiting requested review from mine-man3000

@joebobbio joebobbio Awaiting requested review from joebobbio

@ellyq ellyq Awaiting requested review from ellyq

@ninelore ninelore Awaiting requested review from ninelore

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@death7654 @ninelore @MrChromebox