fix: if statement breaking copy() and ccopy() on macos #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #361.
Problem:
ccopy
andcopy
return an error on mac, "copy: supported only in the Desktop version"This is because the cht.sh script checks for presence of the
$DISPLAY
environment variable, whichis no longer a part of MacOS as it comes from the X11 days. So, calling the function would always
return the error on mac.
pr366 attempted to fix this with a similar approach.
The solution of this PR reuses the
$is_macos
boolean variable, which is already a part of thisscript.
It now only returns the error if
$DISPLAY
is null/empty and the OS is not MacOS.