Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: incorrect CPPN output is used to determine the angle for a robot body module #583

Merged

Conversation

royderegt
Copy link
Contributor

Both angle and module_type use outputs[0] from the CPPN, where one would expect module_type to use outputs[0] and angle to use outputs[1], as can be deduced from this code snippet in class BodyGenotypeOrmV2

        body = MultineatGenotypePickleWrapper(
            random_multineat_genotype(
                [...]
                num_outputs=2,  # block_type, rotation_type
                [...]
            )
        )

See https://github.com/ci-group/revolve2/blob/6d3457af6e9928deacc352a365e2cf910f4d20cd/standards/revolve2/standards/genotypes/cppnwin/modular_robot/v2/_body_genotype_orm_v2.py

@royderegt royderegt changed the base branch from master to development October 18, 2024 16:19
Copy link
Contributor

@andresgr96 andresgr96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@tckarenchiang tckarenchiang merged commit 5ea0a48 into ci-group:development Oct 30, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants