Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple select error TypeError Cannot read properties of null (reading 'length') #1865

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Dec 18, 2024

…fixes cases where the result of get(lastSelection, this.args.searchField) is not guaranteed to be a string

see #1854 (comment)

close #1854

@johanrd
Copy link
Contributor Author

johanrd commented Dec 18, 2024

I guess this could also be solved also by typescript only (probably need to do a lot of conversion from any to generics), but having a failsafe in javascript is good anyways, I think.

@mkszepp mkszepp changed the title fix for #1854 Fix multiple select error TypeError Cannot read properties of null (reading 'length') Dec 19, 2024
@mkszepp
Copy link
Collaborator

mkszepp commented Dec 19, 2024

thank you for debugging and fix

@mkszepp mkszepp merged commit 2e14a8f into cibernox:master Dec 19, 2024
20 checks passed
@mkszepp mkszepp added the bug label Dec 19, 2024
@mkszepp
Copy link
Collaborator

mkszepp commented Dec 19, 2024

Released in v8.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError Cannot read properties of null (reading 'length') on this.searchText.length > 0
2 participants