Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#333 Internationalization and Localization Support #410

Closed
wants to merge 119 commits into from

Conversation

kennethbruskiewicz
Copy link
Collaborator

  • Created a "Template" class for schema and documentation management which responds to locale changes
  • Added support for i18n to be managed through a translation.json file informed by @ddooley
  • Added a "Language" UI component

Next steps:

  • Refactor existing schema injection to use the Template object
  • Test the coupling between the UI component and schema changes
  • Contact researchers requiring localization and get instructed on their use-cases for controls
  • Come up with example data for implementing the internationalization behaviour
  • Show LinkML community the work and address pain-points
    • schemas don't know their language so it's a property of the way templates are packaged

@kennethbruskiewicz kennethbruskiewicz marked this pull request as ready for review September 20, 2023 23:21
@kennethbruskiewicz
Copy link
Collaborator Author

Thanks for working on this PR. We host a version of the Data Harmonizer and having localization support will make our lives easier to address concern from our external partners.

@Takadonet Would you be interested in giving this branch a test run this week? There are a lot of changes, and I would like a user to attempt to use the application to ensure the new features offer a smooth experience.

@kennethbruskiewicz
Copy link
Collaborator Author

kennethbruskiewicz commented Dec 20, 2023

@ddooley I needed to rework the multi select internationalization to have a simpler implementation, particularly so copy-paste was less fragile. I merged the current master with this branch.

@kennethbruskiewicz
Copy link
Collaborator Author

@ddooley I believe you've tested all of the changes made two weeks ago for i18n support (multi select menus are translated, provide values, and switch back and forth between languages; exports are in the default language; cut/paste should work robustly; DH works when opening the main HTML file as well as on a server).

I've also patched the problem with Chrome requiring clicking the localization button twice to get it to change(handle selecting a locale with onChange rather than onClick).

@Takadonet
Copy link
Contributor

Bump.
Any chance that this will be merged in the near future? Theses changes will be awesome to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website localization
4 participants