helm: update livenessProbe to retry 5 times before failing #1407
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
added
the
release-note/minor
willfindlay
force-pushed
the
pr/willfindlay/update-livenessprobe
branch
from
b3eb6bd
to
c39b08b
Compare
We noticed issues in testing where gRPC queries would sometimes spuriously time out, causing our livenessProbe to fail and the Tetragon pod to restart. 7f2edda and 4f4feb8 introduced new configuration values in our CLI to allow it to re-attempt the connection in case of failure. Update our livenessProbe in helm to use these new configuration values so that we can re-attempt the connection. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/update-livenessprobe
branch
from
c39b08b
to
3fbe336
Compare
|
Lgtm |
|
What was the old timeout default value? |
|
@jrfastab it was 1 second with no retries. Now it's 60 with 5 retries (each attempt takes 10 seconds with some extra time for exponential backoff). |
jrfastab
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed issues in testing where gRPC queries would sometimes spuriously time out, causing our livenessProbe to fail and the Tetragon pod to restart. 7f2edda and 4f4feb8 introduced new configuration values in our CLI to allow it to re-attempt the connection in case of failure. Update our livenessProbe in helm to use these new configuration values so that we can re-attempt the connection.