-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProcessCache: Make GC interval configurable #3130
ProcessCache: Make GC interval configurable #3130
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3bfb130
to
43160b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also make this configurable via a helm value as a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just two nits:
- the duration of the tests
- in Go naming we usually keep acronyms in uppercase, so somethingGCSomething, and gcSomething or GCSomething for unexported or exported.
ee53f18
to
fdc8e09
Compare
The process cache delays removal of exited processes. The first time the garbage collector sees a process (marked deletePending), it changes it to deleteReady. The second time it sees the process, it deletes it from the cache. The garbage collector runs every 30s. This commit makes the GC interval configurable with the --process-cache-gc-interval switch. Signed-off-by: Kevin Sheldrake <[email protected]>
Signed-off-by: Kevin Sheldrake <[email protected]>
Signed-off-by: Kevin Sheldrake <[email protected]>
fdc8e09
to
3b5888f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
The process cache delays removal of exited processes. The first time the garbage collector sees a process (marked deletePending), it changes it to deleteReady. The second time it sees the process, it deletes it from the cache. The garbage collector runs every 30s.
This PR makes the GC interval configurable with the --process-cache-gc-interval switch.