secret env refactor

cinaq · Nov 18, 2022 · 3c3800a · 3c3800a
1 parent 06ceae5
commit 3c3800a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 20 deletions.
diff --git a/charts/app-mendix/templates/deployment-leader.yaml b/charts/app-mendix/templates/deployment-leader.yaml
@@ -42,10 +42,10 @@ spec:
             - name: {{ .name | quote}}
               value: {{ .value | quote}}
           {{- end }}
-          {{- if .Values.secretEnv }}
+          {{- if .Values.secretName }}
           envFrom:
             - secretRef:
-              name: {{ template "app-mendix.fullname" $ }}
+              name: {{ .Values.secretName }}
           {{- end }}
           {{- if .Values.readinessProbe.enabled }}
           readinessProbe:

diff --git a/charts/app-mendix/templates/deployment-slave.yaml b/charts/app-mendix/templates/deployment-slave.yaml
@@ -48,10 +48,10 @@ spec:
             - name: {{ .name | quote}}
               value: {{ .value | quote}}
           {{- end }}
-          {{- if .Values.secretEnv }}
+          {{- if .Values.secretName }}
           envFrom:
             - secretRef:
-              name: {{ template "app-mendix.fullname" $ }}
+              name: {{ .Values.secretName }}
           {{- end }}
           {{- if .Values.readinessProbe.enabled }}
           readinessProbe:

diff --git a/charts/app-mendix/templates/secret.yaml b/charts/app-mendix/templates/secret.yaml
diff --git a/charts/app-mendix/values.yaml b/charts/app-mendix/values.yaml
@@ -41,8 +41,6 @@ env: []
   #   value: "test-mx-app"
   # - name: S3_ENDPOINT
   #   value: "http://minio:9000"
-
-secretEnv: []
   # - name: LICENSE_ID
   #   value: xxx
   # - name: LICENSE_KEY
@@ -58,6 +56,12 @@ secretEnv: []
   # - name: S3_SECRET_ACCESS_KEY
   #   value: "accesskey"
 
+# Secret name with mendix application runtime variables. Will be loaded as pod environment variables
+#  Example data
+#  data:
+#   ADMIN_PASSWORD: SGVsbG8wMTIzY2xlYXIK (base64)
+secretName: ""
+
 nodeSelector: {}
 
 tolerations: []