268 Parsing an existing DOI #283
Conversation
|
Netlify Preview Deployment Information |
comment out emulator code and remove unneeded db dump file clean up update readme add heading to readme remove db backup and import on emulator start
|
Visit the preview URL for this PR (updated for commit e650531): https://cioos-metadata-form--pr283-268-parsing-an-exist-iv7oqumk.web.app (expires Sun, 18 Feb 2024 04:40:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 57eda2a7622dc877ccadb675a0532261c52b09fd |
|
Does this do a DOI prefix check? I tried the PR preview link and pasted a random DOI and it seems to let me click the Update button. 
After clicking "Update DOI": added: Also noticing button appears in CIOOS Pacific form, where only Hakai and IYS currently have Datacite connection info |
|
currently it only checks when handeling the the status response. good point on the update. We could disable the buttons if they do not match. Currently the request is sent and datactite would respond with an erorr which is then handled in the could function |
|
This appears to be working as expected. If someone would like to double check it would be appreciated. |
|
It's telling me I have an invalid DOI, assumedly because I don't have the DOI prefix, but the status checking and look up still worked surprisingly. Might be better for the status check and updateability to not work if the doi is entered without the prefix?
When I added the https://doi.org prefix to the URL the It did manage to update the DOI successfully...confirmed that in DataCite. It won't show the status of a this DOI registered outside of Hakai DataCite. This particular DOI was registered with CrossRef and the DataCite REST API does not index those DOIs. For that, the DataCite GraphQL API would be needed. So, any time someone enters a DOI not minted by DataCite, we wont know the status. Maybe that's fine though. |
|
hmmm I get not found when I try to search for that second doi. could be a it's not 'findable' yet 
|
|
there's an extra dash in your url. should be https://doi.org/10.1046/j.1365-294x.1998.00324.x |
|
interesting, it appears to fail on the datacite api side not in our code.
I'm not sure why. maybe it dosn't like the dash. I will have to investigate
more.
|
|
The DataCite REST API doesn't have access to DOIs registered outside of
DataCite such as CrossRef (which is the case for that long URL, it was
published by CrossRef). The DataCite GraphQL API provides access to Graph
Commons which includes both DataCite and CrossRef DOIs.
|
|
ok, well that would do it then. |
|
Yeah. Not sure if it matters we can't get the status of those. Would be nice I guess but doesn't seem critical? |
|
it also looks like we can only get 'findable' doi's via the QraphQL endpoint. Is that your expereince also? In order to get both datacite private doi's and all public we would need two api calls every time. for now I'm happy to stick with what we have. |
|
Yeah that would make sense GraphQL api is only for findable DOIs. I'm happy with what we have too |
|
I was inspired by @sorochak work with the resource URL checks and changed the status message to show up in the 'help text' for the doi field. 
Unless someone has an issue with this, I think we are ready to merge this one |
|
Looks great to me. It even handles the case when I delete the draft DOI directly in DataCite and return to the form to find "DOI Not Found" and the ability to modify the DOI. Looks ready to merge to me too |
#268
update doiCreationStatus on page load/refresh if datasetIdentifier is set