Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update doi on submit #338

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Feature/update doi on submit #338

merged 6 commits into from
Apr 9, 2024

Conversation

BryceMarshall
Copy link
Contributor

@BryceMarshall BryceMarshall commented Mar 28, 2024 •
edited
Loading

Added a call to update DOI with all record information when submit button is pressed

Feedback

  • A single bolded line shows success/failure after submission - too simple?

Documentation

  • Onboarding documents for this project should include references to membership in the admin lists in Firebase (e.g. admin/hakai/permissions/reviewers, which are required to interact with DOI APIs

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 113bb84):

https://cioos-metadata-form--pr338-feature-update-doi-o-6d9ibmb5.web.app

(expires Fri, 03 May 2024 23:00:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 57eda2a7622dc877ccadb675a0532261c52b09fd

fostermh
fostermh reviewed Apr 2, 2024
View reviewed changes
src/components/Pages/MetadataForm.jsx
@@ -254,6 +262,42 @@ class MetadataForm extends FormClassTemplate {
return contactsRef.push(contact).getKey();
}

async handleUpdateDraftDOI() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the same as https://github.com/cioos-siooc/metadata-entry-form/blob/feature/update-doi-on-submit/src/components/Tabs/IdentificationTab.jsx/#L143? Can these be combined to reduce duplicate code?

@fostermh fostermh linked an issue Apr 3, 2024 that may be closed by this pull request
Update DataCite upon submit #300
Closed
@BryceMarshall
Copy link
Contributor Author

I've factored the API logic out - have left the UI logic in place for each.

Does it make sense to unify the display components calling the DOI logic as well? @fostermh

@fostermh fostermh mentioned this pull request Apr 4, 2024
Open
@fostermh
Copy link
Member

fostermh commented Apr 4, 2024

Does it make sense to unify the display components calling the DOI logic as well?

it does and I have that going in another pr

@BryceMarshall BryceMarshall merged commit 7cccb26 into main Apr 9, 2024
3 checks passed
@BryceMarshall BryceMarshall deleted the feature/update-doi-on-submit branch April 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fostermh fostermh fostermh approved these changes

@sorochak sorochak Awaiting requested review from sorochak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DataCite upon submit
2 participants
@BryceMarshall @fostermh