adding provider check #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-rodri
requested review from
josephtate,
elguero,
jallisonciq and
trinity-q
josephtate
reviewed
Oct 30, 2024
| @@ -29,7 +29,7 @@ print(string.sub(hash, 0, 16)) | |||
| Summary: Utilities from the general purpose cryptography library with TLS implementation | |||
| Name: openssl | |||
| Version: 3.0.7 | |||
| Release: 27%{?dist}.0.2.2 | |||
There was a problem hiding this comment.
I know this ship is well sailed, but I'm concerned about bumping at the end here as our dist tags are not very compatible with RHEL/Rocky's. For example, Rocky's dist tag of elMajor[_Minor] in this version, creating 3.0.7-27.el8_10.0.2.2 (for example) will always precede 3.0.7-27.el8_10.ciqfips.0.2.3, because of the .ciqfips being compared against .0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requested that there be a consistent way of determining how the fips.so is being built.
Previously we had 3 different spec files one for gitlab dist, github dist, provider
This PR will allow for a single gitlab/github dist
By specifying the provider variable fips.so will be packaged into openssl-libs
the provider spec file will be a subset of the this spec