Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlflow #8

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Mlflow #8

merged 5 commits into from
Aug 7, 2023

Conversation

ulivc
Copy link
Collaborator

@ulivc ulivc commented Jul 17, 2023

resolves #6

Implementation of Mlflow tracking because there is no possibility to disable tracking for debugging purposes with kedro tracking.

@ulivc ulivc requested a review from stroblme July 17, 2023 08:28
Copy link
Member

@stroblme stroblme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work so far :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to use dictionaries instead of arrays throughout your code as the "standard" return type of your nodes.

@ulivc
Copy link
Collaborator Author

ulivc commented Aug 7, 2023

Thanks for the review, I implemented the advice.

@ulivc ulivc requested a review from stroblme August 7, 2023 08:18
Copy link
Member

@stroblme stroblme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@stroblme stroblme merged commit c7a3bef into main Aug 7, 2023
@eileen-kuehn eileen-kuehn deleted the mlflow branch August 7, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to mlflow tracking
2 participants