Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce TART_EXECUTOR_NESTED env var in order to support nested vir… #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javgarr
Copy link

@javgarr javgarr commented Jan 20, 2025

Introduce TART_EXECUTOR_NESTED env var in order to support nested virtualization (tart >=2.20.0)

More info:
https://tart.run/faq/#nested-virtualization-support
https://github.com/cirruslabs/tart/releases/tag/2.20.0

@javgarr
Copy link
Author

javgarr commented Jan 20, 2025

For your review, @edigaryev

This is currently a blocker for us in order to be able to test against android emulators on VMs running on M4 Mac Mini machines (MacOS 15+)

@edigaryev
Copy link
Contributor

edigaryev commented Jan 20, 2025

Hello @javgarr,

Thank you for your contribution 🙌

We generally strive to expose security-sensitive options as config or prepare arguments, rather than environment variables, whenever possible. This approach provides GitLab Runner administrators greater control over what runs on their hosts, any leaves the rest of the non-sensitive configuration to the CI job writers.

Could you refactor this slightly to make it a --nested argument to prepare stage instead of an environment variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants