Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to standard results display #4450

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix to standard results display #4450

merged 1 commit into from
Feb 19, 2025

Conversation

randywoods
Copy link
Collaborator

Goes hand in hand with a fix to usp_getStandardResultsByCategory

🗣 Description

A quick fix to prevent a crash when Category names don't align with Question_Group_Headings on a requirements-mode assessment.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Goes hand in hand with a fix to usp_getStandardResultsByCategory
@Marcus-Goectau Marcus-Goectau merged commit 3e50424 into develop Feb 19, 2025
2 checks passed
@Marcus-Goectau Marcus-Goectau deleted the category-fix branch February 19, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants