Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Request Static IP Address #111

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Feature: Request Static IP Address #111

wants to merge 15 commits into from

Conversation

KJStick
Copy link
Contributor

@KJStick KJStick commented Mar 15, 2023

No description provided.

@KJStick KJStick changed the base branch from main to dev March 15, 2023 13:40
@KJStick KJStick changed the title added request ip initial feature Feature: Request Static IP Address Mar 18, 2023
ppajersk
ppajersk requested changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@ppajersk ppajersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, can probably address alot of this stuff on a call

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KJStick KJStick requested a review from ppajersk June 15, 2023 20:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppajersk ppajersk Awaiting requested review from ppajersk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KJStick @ppajersk