Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for et-al-min and et-al-use-first #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgd
Copy link

@georgd georgd commented Apr 20, 2022

Description

See discussion in citation-style-language/documentation#141

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Variable addition (adds a new variable or type string)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have installed the repo pre-commit hook; if not, and I have modified any of the schema files, I have run trang and/or prettier on the files, per CONTRIBUTING
  • I have performed a self-review of my own code
  • I have included suggested corresponding changes to the documentation (if relevant)

@bwiernik
Copy link
Member

bwiernik commented Apr 21, 2022

Thanks!

@denismaier @bdarcus How should we handle bug fixes like this? As x.x.x.1 point releases or just update the 1.0.2 release?

@denismaier
Copy link
Member

Good question, I've been thinking about this as well recently. (I've been pondering whether we could be more lenient when adding new terms. As this doesn't seem to affect processors they could probably added to the existing schema as well.)

Anyway, one option I was thinking about was to use a timestamp for these kind of additions, similar to emacs package versioning on melpa: e.g. https://melpa.org/#/citar

Like, if we added this today we'd still be on CSL 1.0.2, but we'd add a timestamp "20220421" or so to indicate these additions.

But, I can't really estimate how that might affect the larger ecosystem.

@bdarcus
Copy link
Member

bdarcus commented Mar 28, 2023

Seems this got stalled. Where do we stand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants