open api scenario generator #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
commented
Nov 24, 2024
| @@ -37,6 +38,7 @@ | |||
| * @author Christoph Deppisch | |||
| */ | |||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
this should be reverted
| OpenApiServerResponseActionBuilder sendMessageBuilder = openApiServerActionBuilder.send( | ||
| oasOperation.operationId, "200").enableRandomGeneration(false); | ||
| sendMessageBuilder.message().body(format("{\"id\": %d, \"pingTime\": %d}", | ||
| getIdFromPingRequest(receivedMessage), System.currentTimeMillis())); |
There was a problem hiding this comment.
Suggested change
| getIdFromPingRequest(receivedMessage), System.currentTimeMillis())); | |
| getIdFromPingRequest(receivedMessage), currentTimeMillis())); |
please use static import for this.
| @Bean | ||
| public HttpClient petstoreClientV3() { | ||
| return CitrusEndpoints.http().client() | ||
| .requestUrl(String.format("http://localhost:%s/petstore/api/v3", 8080)) |
There was a problem hiding this comment.
Suggested change
| .requestUrl(String.format("http://localhost:%s/petstore/api/v3", 8080)) | |
| .requestUrl(format("http://localhost:%s/petstore/api/v3", 8080)) |
| .header("Ping-Time", "@isNumber()@") | ||
| .validate(jsonPath() | ||
| .expression("$.id", "5000") | ||
| .expression("$.pingCount", "@greaterThan("+expectedPingLimit+")@")) |
There was a problem hiding this comment.
I think this file needs a ctrl+alt + l. there are some static imports that could be adjusted as well, e.g. MediaType and HttpStatus.
| private List<HttpScenario> filterScenarios(Collection<SimulatorScenario> allScenarios) { | ||
| return allScenarios.stream().filter(HttpScenario.class::isInstance) | ||
| .map(HttpScenario.class::cast) | ||
| .sorted(new HttpPathSpecificityComparator()) |
There was a problem hiding this comment.
couldn't this be a singleton? why is it stateful? I think the initialization per request could have performance impact. correct me if I am wrong!
tschlat
force-pushed
the
issue/285/open_api_scenario_generator_TS_2
branch
from
c65e307
to
3bd51b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires citrusframework/citrus#1224