Fix: NPE in case of response header without required attribute (#1171)

* fix: NPE in case of response header without required attribute in OpenAPI

* Remove @author tag

* Add test for Oas30ModelHelper.getRequiredHeaders(..)

---------

Co-authored-by: Ralf Ueberfuhr <[email protected]>

connectors/citrus-openapi/src/main/java/org/citrusframework/openapi/model/v3/Oas30ModelHelper.java

@@ -219,7 +219,7 @@ public static Map<String, OasSchema> getRequiredHeaders(Oas30Response response)
 
         return response.headers.entrySet()
                 .stream()
-                .filter(entry -> entry.getValue().required)
+                .filter(entry -> Boolean.TRUE.equals(entry.getValue().required))
                 .collect(Collectors.toMap(Map.Entry::getKey, entry -> entry.getValue().schema));
     }
 

connectors/citrus-openapi/src/test/java/org/citrusframework/openapi/model/v3/Oas30ModelHelperTest.java

@@ -0,0 +1,54 @@
+package org.citrusframework.openapi.model.v3;
+
+import io.apicurio.datamodels.openapi.models.OasSchema;
+import io.apicurio.datamodels.openapi.v3.models.Oas30Header;
+import io.apicurio.datamodels.openapi.v3.models.Oas30Response;
+import io.apicurio.datamodels.openapi.v3.models.Oas30Schema;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import java.util.Map;
+
+public class Oas30ModelHelperTest {
+
+    @Test
+    public void shouldNotFindRequiredHeadersWithoutRequiredAttribute() {
+        var header = new Oas30Header("X-TEST");
+        header.schema = new Oas30Schema();
+        header.required = null; // explicitely assigned because this is test case
+        var response = new Oas30Response("200");
+        response.headers.put(header.getName(), header);
+
+        Map<String, OasSchema> result = Oas30ModelHelper.getRequiredHeaders(response);
+
+        Assert.assertEquals(result.size(), 0);
+    }
+
+    @Test
+    public void shouldFindRequiredHeaders() {
+        var header = new Oas30Header("X-TEST");
+        header.schema = new Oas30Schema();
+        header.required = Boolean.TRUE; // explicitely assigned because this is test case
+        var response = new Oas30Response("200");
+        response.headers.put(header.getName(), header);
+
+        Map<String, OasSchema> result = Oas30ModelHelper.getRequiredHeaders(response);
+
+        Assert.assertEquals(result.size(), 1);
+        Assert.assertSame(result.get(header.getName()), header.schema);
+    }
+
+    @Test
+    public void shouldNotFindOptionalHeaders() {
+        var header = new Oas30Header("X-TEST");
+        header.schema = new Oas30Schema();
+        header.required = Boolean.FALSE; // explicitely assigned because this is test case
+        var response = new Oas30Response("200");
+        response.headers.put(header.getName(), header);
+
+        Map<String, OasSchema> result = Oas30ModelHelper.getRequiredHeaders(response);
+
+        Assert.assertEquals(result.size(), 0);
+    }
+
+}